Fix spelling error in os_str.rs #133913
Closed
Fix spelling error in os_str.rs #133913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Noratrieb (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
Kijewski
reviewed
Dec 5, 2024
| /// and platform-native string values, and in particular allowing a Rust string | ||
| /// to be converted into an "OS" string with no cost if possible. A consequence | ||
| /// of this is that `OsString` instances are *not* `NUL` terminated; in order | ||
| /// of this is that `OsString` instances are *not* `NULL` terminated; in order |
Contributor
There was a problem hiding this comment.
NUL is the correct spelling. Wikipedia: Null character.
Member
|
As pointed out by @Kijewski, this is correct. Thank you for the PR anyways :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUL -> NULL